Remove deprecated Python settings - #625
Conversation
Samruddhi Khandale (samruddhikhandale)
left a comment
Samruddhi Khandale (samruddhikhandale)
left a comment
There was a problem hiding this comment.
Thank you for taking the time to contribute this PR, we appreciate it! ✨
|
Took the liberty to remove the linters and formatters from DEFAULT_UTILS, but happy to revert if it not appropriate! 😊 |
|
Samruddhi Khandale (@samruddhikhandale) friendly ping 😊 |
Samruddhi Khandale (samruddhikhandale)
left a comment
Samruddhi Khandale (samruddhikhandale)
left a comment
There was a problem hiding this comment.
Thanks for the ping, apologies to have missed this!
Left some comments.
This reverts commit 57c7bec.
|
Last commit reverted 😊 |
|
Samruddhi Khandale (@samruddhikhandale) friendly ping! |
|
Luciana Abud (@luabud) I had been waiting for this comment https://github.com/devcontainers/features/pull/625/files#r1286251867 Can you help resolve it, then we could merge this PR. Thanks! |
|
Samruddhi Khandale (@samruddhikhandale) oh I'm so sorry! I had totally misunderstood that this would be done in a follow up clean up PR (which I now realize was about bumping the major version, instead of minor 🤦♀️) Just bumped the version to it to 1.2.1 :) thanks a lot! |
Samruddhi Khandale (samruddhikhandale)
left a comment
Samruddhi Khandale (samruddhikhandale)
left a comment
There was a problem hiding this comment.
Looks great, thank you so much! 🎉
3 participants
Hi there!
The
python.lintingandpython.formattingsettings have been deprecated as in the latest Python extension pre-release version, as we're migrating our tooling support to extensions (see here for more details).We figured we'd submit PRs to remove them from devcontainers configs 😊